Add Datadog GlobalTags support #9266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
kind/enhancement
sdelicata
force-pushed
the
feat_datadog_globaltags
branch
2 times, most recently
from
83bc159
to
513171f
Compare
ldez
reviewed
Aug 22, 2022
sdelicata
force-pushed
the
feat_datadog_globaltags
branch
from
6fd34b4
to
91f364d
Compare
sdelicata
force-pushed
the
feat_datadog_globaltags
branch
from
91f364d
to
5458a9d
Compare
mpl
approved these changes
Sep 6, 2022
pkg/tracing/datadog/datadog.go
Outdated
Comment on lines
49
to
62
| if c.GlobalTag != "" { | ||
| log.WithoutContext().Warn(`Datadog: option "globalTag" is deprecated, please use "globalTags" instead.`) | ||
|
|
||
| value := "" | ||
| if len(tag) == 2 { | ||
| value = tag[1] | ||
| key, value, _ := strings.Cut(c.GlobalTag, ":") | ||
|
|
||
| // Don't override a tag already defined with the new option. | ||
| if _, ok := c.GlobalTags[key]; !ok { | ||
| if c.GlobalTags == nil { | ||
| c.GlobalTags = make(map[string]string) | ||
| } | ||
|
|
||
| c.GlobalTags[key] = value | ||
| } | ||
| } |
There was a problem hiding this comment.
imho, it would have been better to make them mutually exclusive as soon as possible in the flow. It is highly unlikely the user purposefully uses both options at the same time, so we would do them a favor by detecting it, telling them to clean up their conf, and stopping.
But whatever, the option is going to disappear soon anyway.
sdelicata
force-pushed
the
feat_datadog_globaltags
branch
from
12f817d
to
caa364a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new
GlobalTagsoption for Datadog tracing.The previous
GlobalTagoption has been deprecated.Motivation
More
[ ] Added/updated tests[ ] Added/updated documentationAdditional Notes