Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry middleware on panic #9284

Merged
merged 1 commit into from Aug 29, 2022
Merged

Fix retry middleware on panic #9284

merged 1 commit into from Aug 29, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 29, 2022

What does this PR do?

don't retry on panic

Motivation

Fixes #9188

Closes #9204

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added this to the 2.8 milestone Aug 29, 2022
@ldez ldez added this to To review in v2 via automation Aug 29, 2022
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 25027d6 into traefik:v2.8 Aug 29, 2022
v2 automation moved this from To review to Done Aug 29, 2022
@ldez ldez deleted the fix/retry-panic branch August 29, 2022 09:39
@rtribotte rtribotte changed the title fix: don't retry on panic Fix retry middleware on panic Sep 2, 2022
@rtribotte rtribotte mentioned this pull request Sep 5, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants