Fix Docker provider mem leak on operation retries #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
area/provider/docker
kind/bug/fix
rtribotte
force-pushed
the
fix-memleak-docker-client
branch
from
063460d
to
acadc5b
Compare
mpl
approved these changes
Aug 30, 2022
rtribotte
changed the title
traefiker
force-pushed
the
fix-memleak-docker-client
branch
from
acadc5b
to
d498b26
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a memory leak that would occur when the Docker provider operation retries, because old connections were not closed properly.
Motivation
Fixes #8872
More
Additional Notes
Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com