Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing networking apiGroup in Kubernetes RBACs examples and references #9295

Merged
merged 3 commits into from Sep 2, 2022

Conversation

fibsifan
Copy link
Contributor

What does this PR do?

Improve the kubernetes ingress configuration example. RBAC updated so traefik can set the ingress status.

Motivation

With the documented example I got an rbac error when traefik tried to update the ingress status.

More

Additional Notes

@rtribotte rtribotte added kind/enhancement a new or improved feature. area/documentation kind/bug/fix a bug fix and removed status/0-needs-triage kind/enhancement a new or improved feature. labels Sep 1, 2022
@rtribotte rtribotte added this to To review in v2 via automation Sep 1, 2022
@rtribotte rtribotte added this to the 2.8 milestone Sep 1, 2022
@rtribotte rtribotte changed the title Improve K8s ingress example Add missing networking apiGroup in Kubernetes RBACs examples and references Sep 2, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9a82d96 into traefik:v2.8 Sep 2, 2022
v2 automation moved this from To review to Done Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants