Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 addr with square brackets #9313

Merged
merged 6 commits into from Sep 9, 2022
Merged

Fix IPv6 addr with square brackets #9313

merged 6 commits into from Sep 9, 2022

Conversation

moonlightwatch
Copy link
Contributor

What does this PR do?

Fix the function parseHost got different result from the host [ipv6Address] and the host [ipv6Address]:8000

Motivation

I have set the entryPoint on the port 80. And a router rule set as Host(ipv6address).
Send a request by curl : curl http://[ipv6address]/,I found the RequestDecorator parse the host to [ipv6address].
I try to set the port to 8080, and do curl http://[ipv6address]:8080/. The RequestDecorator parse the host to ipv6address.

More

  • updated tests
  • updated documentation

@ldez
Copy link
Member

ldez commented Sep 8, 2022

hello, can you prefer rebase over merge when you want to update your PR?

FYI, the PRs are automatically squashed and rebased when we merge a PR, you just have to rebase if your PR has conflicts.

@ldez
Copy link
Member

ldez commented Sep 8, 2022

You have missed something, I will clean your PR.
Screenshot 2022-09-08 at 12-48-24 Fix_ipv6 addr in square brackets by moonlightwatch · Pull Request #9313 · traefik_traefik

@ldez
Copy link
Member

ldez commented Sep 8, 2022

By default, you don't need to rebase or update your PR.
If we ask you some changes, you just have to create a new commit.
When the review will be done, our bot will rebase and squash your PR before the merge.

@moonlightwatch
Copy link
Contributor Author

Thank you. I will do better next time.

@rtribotte rtribotte added this to To review in v2 via automation Sep 8, 2022
@rtribotte rtribotte changed the base branch from master to v2.8 September 8, 2022 13:28
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rtribotte rtribotte added this to the 2.8 milestone Sep 8, 2022
@ldez ldez changed the title Fix/ipv6 addr in square brackets fix: IPv6 addr in square brackets Sep 9, 2022
@ldez ldez removed the bot/no-merge label Sep 9, 2022
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 77c8d60 into traefik:v2.8 Sep 9, 2022
v2 automation moved this from To review to Done Sep 9, 2022
@rtribotte rtribotte changed the title fix: IPv6 addr in square brackets Fix IPv6 addr with square brackets Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants