Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update valkeyrie to v1.0.0 #9316

Merged
merged 4 commits into from Sep 12, 2022
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 8, 2022

What does this PR do?

Update Valkeyrie to v1.0.0.

  • remove unused options
  • add username and DB to Redis store

Fixes #9156
Fixes #9304

Motivation

Be able to get a more accurate configuration by store.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@traefiker traefiker merged commit d531963 into traefik:master Sep 12, 2022
v2 automation moved this from To review to Done Sep 12, 2022
@ldez ldez deleted the feat/update-valkeyrie branch September 12, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

Support Redis 6.x/7.x specified username Support connecting to a specific Redis database
5 participants