New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update valkeyrie to v1.0.0 #9316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
a new or improved feature.
status/2-needs-review
area/provider/consul
area/provider/etcd
area/provider/kv
area/provider/redis
labels
Sep 8, 2022
ldez
force-pushed
the
feat/update-valkeyrie
branch
from
September 8, 2022 22:26
f8428f6
to
97acb76
Compare
rtribotte
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
kevinpollet
force-pushed
the
feat/update-valkeyrie
branch
from
September 12, 2022 14:56
35db3ac
to
e17e8af
Compare
kevinpollet
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
mmatur
approved these changes
Sep 12, 2022
traefiker
force-pushed
the
feat/update-valkeyrie
branch
from
September 12, 2022 15:17
e17e8af
to
833e6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/provider/consul
area/provider/etcd
area/provider/kv
area/provider/redis
area/provider/zk
kind/enhancement
a new or improved feature.
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Valkeyrie to v1.0.0.
Fixes #9156
Fixes #9304
Motivation
Be able to get a more accurate configuration by store.
More
Additional Notes