Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECS Anywhere #9324

Merged
merged 8 commits into from Sep 14, 2022

Conversation

tuxpower
Copy link
Contributor

What does this PR do?

Add support for self-managed on-premise infrastructure with ECS Anywhere.

Motivation

Extend ECS provider.

Fixes #8795

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

make validate fails with the following error:

docker run -v "/var/run/docker.sock:/var/run/docker.sock"   -e OS_ARCH_ARG -e OS_PLATFORM_ARG -e TESTFLAGS -e VERBOSE -e VERSION -e CODENAME -e TESTDIRS -e CI -e CONTAINER=DOCKER		 -v "/home/jgaspar/Documents/repos/traefik/dist:/go/src/github.com/traefik/traefik/dist" "traefik-dev:feature-ecs-anywhere" ./script/make.sh generate validate-lint validate-misspell validate-vendor
---> Making bundle: generate (in /go/src/github.com/traefik/traefik/script)

---> Making bundle: validate-lint (in /go/src/github.com/traefik/traefik/script)
pkg/provider/ecs/ecs.go:210: Function 'listInstances' is too long (249 > 230) (funlen)
func (p *Provider) listInstances(ctx context.Context, client *awsClient) ([]ecsInstance, error) {
make: *** [Makefile:139: validate] Error 1

That's because I had to duplicate some of the code for managed instances ending up on a much bigger function.

@tuxpower tuxpower mentioned this pull request Sep 12, 2022
2 tasks
@tuxpower tuxpower changed the title Add support for ECS Anywhere #9127 Add support for ECS Anywhere Sep 12, 2022
@tuxpower
Copy link
Contributor Author

tuxpower commented Sep 12, 2022

This PR replaces #9127 as requested by @mmatur.
#9127 (comment)

@mmatur mmatur force-pushed the feature/support-ecs-anywhere branch 3 times, most recently from 6ad0db9 to 8db7355 Compare September 13, 2022 06:43
@mmatur mmatur added this to the 2.9 milestone Sep 14, 2022
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼 🎉

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼 🎉

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ECS Anywhere
5 participants