Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty plugin configuration #9338

Merged
merged 1 commit into from Sep 15, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 15, 2022

What does this PR do?

Allows using of an empty config for a plugin.

Motivation

Fixes #9337

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added status/2-needs-review kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. area/plugins labels Sep 15, 2022
@ldez ldez added this to the 2.9 milestone Sep 15, 2022
@ldez ldez added this to To review in v2 via automation Sep 15, 2022
@ldez ldez changed the base branch from v2.9 to v2.8 September 15, 2022 08:17
@ldez ldez modified the milestones: 2.9, 2.8 Sep 15, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ldez ldez changed the title plugin: allow empty config plugins: allow empty config Sep 15, 2022
@traefiker traefiker merged commit d06573d into traefik:v2.8 Sep 15, 2022
v2 automation moved this from To review to Done Sep 15, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Sep 15, 2022
@ldez ldez deleted the fix/plugin-empty-config branch September 15, 2022 09:08
@kevinpollet kevinpollet changed the title plugins: allow empty config Allow empty plugin config Sep 23, 2022
@kevinpollet kevinpollet changed the title Allow empty plugin config Allow empty plugin configuration Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants