Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AddServer algorithm #9358

Merged
merged 3 commits into from Sep 21, 2022
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 21, 2022

What does this PR do?

Simplifying AddServer algorithms.

Motivation

Have readable algorithms.

same approach as #9357

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ldez ldez changed the title providers: clean AddServer algorithms providers: simplify AddServer algorithms Sep 21, 2022
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7ac687a into traefik:v2.8 Sep 21, 2022
v2 automation moved this from To review to Done Sep 21, 2022
@ldez ldez deleted the fix/clean-add-server branch September 21, 2022 13:04
@kevinpollet kevinpollet changed the title providers: simplify AddServer algorithms Simplify AddServer algorithm Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants