Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize websocket headers handling #9360

Merged
merged 1 commit into from Sep 22, 2022

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 21, 2022

What does this PR do?

Improves performance for non websocket upgrade requests.

Motivation

Improve performance !!!!!!

More

- [ ] Added/updated tests
- [ ] Added/updated documentation

Additional Notes

Before

Running 30s test @ http://traefik/bench
  4 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.63ms    1.11ms  44.00ms   81.79%
    Req/Sec    16.22k     1.23k   54.86k    99.17%
  Latency Distribution
     50%    1.42ms
     75%    2.07ms
     90%    2.87ms
     99%    5.03ms
  1938441 requests in 30.10s, 188.56MB read
Requests/sec:  64401.47
Transfer/sec:      6.26MB

After

Running 30s test @ http://traefik/bench
  4 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.56ms    1.04ms  53.60ms   81.83%
    Req/Sec    16.93k   532.62    18.78k    93.25%
  Latency Distribution
     50%    1.36ms
     75%    1.97ms
     90%    2.71ms
     99%    4.79ms
  2021318 requests in 30.02s, 196.62MB read
Requests/sec:  67331.54
Transfer/sec:      6.55MB

Co-authored-by: Kevin Pollet pollet.kevin@gmail.com

@juliens juliens added this to the 2.8 milestone Sep 21, 2022
@juliens juliens added this to To review in v2 via automation Sep 21, 2022
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 9cd54ba into traefik:v2.8 Sep 22, 2022
v2 automation moved this from To review to Done Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants