Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACME panic #9365

Merged
merged 2 commits into from Sep 23, 2022
Merged

Fix ACME panic #9365

merged 2 commits into from Sep 23, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 22, 2022

What does this PR do?

fix: acme panic

Motivation

Fixes #9364

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.9 milestone Sep 22, 2022
@ldez ldez added this to To review in v2 via automation Sep 22, 2022
kevinpollet
kevinpollet approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bb66950 into traefik:v2.9 Sep 23, 2022
v2 automation moved this from To review to Done Sep 23, 2022
@traefiker traefiker mentioned this pull request Sep 23, 2022
Closed
2 tasks
@kevinpollet kevinpollet changed the title fix: acme panic Fix ACME panic Sep 23, 2022
@ldez ldez deleted the fix/acme-resolve branch September 23, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@kevinpollet kevinpollet kevinpollet approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @kevinpollet @mmatur @traefiker