Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework metrics overview page #9366

Merged
merged 3 commits into from Sep 23, 2022
Merged

Rework metrics overview page #9366

merged 3 commits into from Sep 23, 2022

Conversation

ddtmachado
Copy link
Contributor

@ddtmachado ddtmachado commented Sep 23, 2022 •
edited by ldez

What does this PR do?

Rework the metrics overview page without adding or removing content.

Motivation

Better readability and ease of use for when you want to scroll or search for the available metrics in one of the supported backends. This is the list of changes:

  • The name of the metric should reflect the representation on the backend to avoid confusion. Ex: HTTP Request Total Count -> Requests total (prometheus: traefik_<entrypoint|router|service>_requests_total)
  • The type of the metric is removed from the name and added into a dedicated column
  • Labels are now displayed on a column
  • The description of the metric is now displayed in a column
  • All backend representations are grouped after the overview table

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I always struggled with the layout of this page in particular and I feel this is better for quick lookups and user exposition to available metrics and labels on each level.

ldez
ldez approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Sep 23, 2022
@ldez ldez added this to the 2.9 milestone Sep 23, 2022
kevinpollet
kevinpollet approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a63d5c9 into traefik:v2.9 Sep 23, 2022
v2 automation moved this from To review to Done Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/metrics kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ddtmachado @kevinpollet @mmatur @ldez @traefiker