New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for publishedService and IP options #9380
Conversation
Closes traefik#8406. Signed-off-by: Skyler Mäntysaari <samip5@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear good.
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Hi @kevinpollet. I'm little sad that you modified the issue description to add the "fixes" as this doesn't in reality fix the underlying bug which is in using Endpoints instead of EndpointSlices. The bug itself is still in the code. |
Hello @samip5, and sorry for that, I missed something. |
It's right there #8406 (comment) and has been for multiple years. |
Hello @samip5, If I am not mistaken, issue #8406 was about copying the LoadBalancer service IPs to the Ingress status. This is working as expected by using the The following comment #8406 (comment) is about the IPs used for load balancing, which seems to contain only one IP Family. If there is an issue with IPv6 or dual stack clusters, it would be easier to open a new issue to be able to address it properly. Could you please open this new issue describing the problem? |
You're unfortunately mistaken, as the original one was also about EndpointSlices (currently the copying only copies the first IP family due to the issue of not using EndpointSlices aka #8406 (comment)), not just copying the status thus it shouldn't have been closed when the PR was merged for docs. |
Hi @samip5 |
It already has been explained (multiple times, mind you, even in the Hackathon), but no matter how I try to explain it, it seems maintainers will not understand my point, so I will rather just not use Traefik. Maybe @aojea wants to explain the problem, but I have already tried to no avail. |
I'm sorry, but that's how most open source project works: to report problems through issues. |
What does this PR do?
Makes it more clear what the kubernetes-ingress options actually do. like ip and publishedService.
Motivation
Hackaeton and the long-lasting issue #8406.
Fixes #8406
More