Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoDiscoverClusters option documentation for ECS provider #9392

Conversation

johnpekcan
Copy link
Contributor

@johnpekcan johnpekcan commented Sep 29, 2022

What does this PR do?

This PR aims to clarify the documentation regarding the relationship between autoDiscoverClusters and clusters in the ECS provider.

Motivation

Fix #9385

More

  • Added/updated documentation

Additional Notes

Received feedback from @kevinpollet on my initial issue , and was asked to update the documentation -- as this was the intended functionality.

@johnpekcan
Copy link
Contributor Author

@kevinpollet Here's the PR to update the docs!
Please let me know if there's anything else you'd like to see changed 🍻

@kevinpollet kevinpollet changed the title update documentation for ECS provider to clarify autoDiscoverClusters option Fix autoDiscoverClusters option documentation for ECS provider Sep 30, 2022
@kevinpollet kevinpollet added this to To review in v2 via automation Sep 30, 2022
@kevinpollet kevinpollet added this to the 2.8 milestone Sep 30, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rtribotte rtribotte added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Sep 30, 2022
johnpekcan and others added 2 commits September 30, 2022 10:51
… option

Signed-off-by: John Pekcan <johnpekcan@gmail.com>
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
@ldez ldez force-pushed the b/jpekcan/clarify-documentation-in-ecs-provider-regarding-autodiscovery branch from 52c91a3 to 45c452d Compare September 30, 2022 08:51
@traefiker traefiker merged commit 6271756 into traefik:v2.8 Sep 30, 2022
v2 automation moved this from To review to Done Sep 30, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Sep 30, 2022
@johnpekcan johnpekcan deleted the b/jpekcan/clarify-documentation-in-ecs-provider-regarding-autodiscovery branch October 6, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants