Remove raw cert escape in PassTLSClientCert middleware #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
force-pushed
the
fix-unescape-tls-client-cert
branch
from
e561eb2
to
0a7ddd1
Compare
traefiker
force-pushed
the
fix-unescape-tls-client-cert
branch
from
0a7ddd1
to
b1048e6
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the escaping of the raw client cert as a value for the
X-Forwarded-Tls-Client-Certheader.Motivation
As discussed in #9379, the escape form of the raw client cert is not always supported/expected on backends, as with PhenixID.
Fixes #9379
More
Additional Notes
Supersedes #9411