New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of allowEmptyServices in TraefikService #9424
Conversation
Hello, can you explain the draft state of this PR? Because if it's a draft we will not review it. |
Hello, The draft status was because I wanted to make sure about the tests. I added one instead of changing an existing one. It is done now. Thanks |
3d015bc
to
f79440e
Compare
Hello @jeromeguiard, We thought about the changes and about the use case, and here are our takes:
|
eb1c1ab
to
591bd17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
591bd17
to
63fdfa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
What does this PR do?
This PR fix issue #9423 related to flag not taken into account for traefik service
Motivation
It is a bug in the configBuilder object that doesn't represent expected code behavior
Fixes #9423
More