Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis configuration type #9435

Merged
merged 2 commits into from Oct 13, 2022
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 13, 2022

What does this PR do?

Use a pointer for the Redis configuration.

Update the Valkeyrie module to detect the invalid configuration type:

Motivation

Fixes #9416

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Oct 13, 2022
@traefiker traefiker added this to the 2.9 milestone Oct 13, 2022
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0ca1c8a into traefik:v2.9 Oct 13, 2022
v2 automation moved this from To review to Done Oct 13, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Oct 13, 2022
@ldez ldez added the kind/bug/fix a bug fix label Oct 13, 2022
@ldez ldez deleted the fix/redis-configuration branch October 13, 2022 16:41
@kevinpollet kevinpollet changed the title fix: redis configuration type Fix Redis configuration type Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants