Handle capture on redefined http.responseWriters #9440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
force-pushed
the
fix-capture-middleware
branch
from
568723e
to
d617482
Compare
ldez
force-pushed
the
fix-capture-middleware
branch
from
d617482
to
9d2c01d
Compare
kevinpollet
force-pushed
the
fix-capture-middleware
branch
from
395c6ac
to
e0eca99
Compare
mpl
approved these changes
Oct 27, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes incorrect values that could be filled in services metrics when a middleware interferes in the chain and redefines the
http.responseWriter.Motivation
Fixes #9407
More
Additional Notes
Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com