Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dashboard rule example #9454

Merged
merged 1 commit into from Oct 18, 2022
Merged

Simplify dashboard rule example #9454

merged 1 commit into from Oct 18, 2022

Conversation

sosoba
Copy link
Contributor

@sosoba sosoba commented Oct 18, 2022

What does this PR do?

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

PathPrefix carries out the logical or himself.

@ldez ldez changed the title Simplifying the rule doc: dashboad simplifying a rule Oct 18, 2022
@kevinpollet kevinpollet added this to To review in v2 via automation Oct 18, 2022
@kevinpollet kevinpollet changed the base branch from master to v2.9 October 18, 2022 13:14
@kevinpollet kevinpollet changed the title doc: dashboad simplifying a rule Simplify dashboard rule example Oct 18, 2022
@ldez ldez added this to the 2.9 milestone Oct 18, 2022
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kevinpollet kevinpollet added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Oct 18, 2022
@traefiker traefiker merged commit 8128d6c into traefik:v2.9 Oct 18, 2022
v2 automation moved this from To review to Done Oct 18, 2022
@traefiker traefiker added bot/need-human-merge and removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Oct 18, 2022
@sosoba sosoba deleted the patch-1 branch October 19, 2022 04:38
@netsandbox
Copy link

@tfny
Copy link
Contributor

tfny commented Nov 16, 2022

@netsandbox, Thanks for catching that. You are right, while the current documentation is true, it is not optimized. Will you be willing to open a PR to help us update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants