Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove side effect on default transport tests #9460

Merged
merged 1 commit into from Oct 24, 2022

Conversation

sdelicata
Copy link
Contributor

@sdelicata sdelicata commented Oct 21, 2022

What does this PR do?

This PR removes side effects on default transport, that don't have to be altered.

Motivation

Fixes side effects

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Oct 21, 2022
@ldez ldez force-pushed the fix_test_default_transport branch from 95a4b0b to 4b8ce43 Compare October 21, 2022 16:46
@ldez ldez changed the base branch from master to v2.9 October 21, 2022 16:46
@ldez ldez added this to the 2.9 milestone Oct 21, 2022
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix_test_default_transport branch from 4b8ce43 to 0891ec6 Compare October 22, 2022 11:19
@ldez ldez added status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. and removed status/2-needs-review labels Oct 24, 2022
@traefiker traefiker merged commit ccbbd0d into traefik:v2.9 Oct 24, 2022
v2 automation moved this from To review to Done Oct 24, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants