Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify PathPrefix matcher greediness #9519

Merged
merged 1 commit into from Nov 21, 2022
Merged

Clarify PathPrefix matcher greediness #9519

merged 1 commit into from Nov 21, 2022

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Nov 21, 2022

What does this PR do?

This PR clarifies that the PathPrefix matcher is very greedy and does not care about / as a separator.

Motivation

Fixes #9514

More

- [ ] Added/updated tests

  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.9 milestone Nov 21, 2022
@ldez ldez added this to To review in v2 via automation Nov 21, 2022
@ldez ldez added the kind/enhancement a new or improved feature. label Nov 21, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit af4e74c into traefik:v2.9 Nov 21, 2022
v2 automation moved this from To review to Done Nov 21, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Nov 21, 2022
@tomMoulard tomMoulard changed the title doc: clarify PathPrefix greediness Clarify PathPrefix matcher greediness Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants