Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timeout on plugin download #9529

Merged
merged 1 commit into from Nov 22, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 22, 2022

What does this PR do?

Increase the timeout on plugin download

Motivation

Fixes #9512

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added status/2-needs-review kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. area/plugins labels Nov 22, 2022
@ldez ldez added this to the 2.9 milestone Nov 22, 2022
@ldez ldez added this to To review in v2 via automation Nov 22, 2022
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title fix: increase the timeout on plugin download Increase the timeout on plugin download Nov 22, 2022
@traefiker traefiker merged commit 81a5b1b into traefik:v2.9 Nov 22, 2022
v2 automation moved this from To review to Done Nov 22, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Nov 22, 2022
@traefiker traefiker mentioned this pull request Nov 22, 2022
2 tasks
@ldez ldez deleted the fix/plugin-timeout branch November 22, 2022 17:30
@milindpatel63
Copy link

milindpatel63 commented Apr 7, 2023

I have had exact same issue as to this one #9512 since I have setup traefik for more than a year now. If it is a network issue it has been consistent for me for more than a year now.
Basically almost every time my server restarts or my traefik container get's updated via watchtower and restarts, either it goes fine 10% of the time, or i'l have to manually check docker logs to find that plugin has not loaded due to a network issue, and all my services are not working since they depend on that plugin as a middleware. I'll have to manually restart traefik docker container multiple times, sometimes like 30 times after which the plugin gets downloaded and everything works.

This has been a consistent issue for me. I have a pretty decent fiber internet 300up and 300down in India.

Here's the latest error

time="2023-04-07T08:16:06+05:30" level=info msg="Traefik version 2.9.10 built on 2023-04-06T16:15:08Z"
time="2023-04-07T08:16:07+05:30" level=info msg="\nStats collection is disabled.\nHelp us improve Traefik by turning this feature on :)\nMore details on: https://doc.traefik.io/traefik/contributing/data-collection/\n"
time="2023-04-07T08:16:22+05:30" level=error msg="Plugins are disabled because an error has occurred." error="failed to download plugin github.com/Paxxs/traefik-get-real-ip: failed to call service: Get \"https://plugins.traefik.io/public/download/github.com/Paxxs/traefik-get-real-ip/v1.0.2\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"

I looked into setting up local plugin repository for traefik, but wasn't able to set it up successfully, so I just gave up and added a manual task to reboot traefik container in my server spin-up checklist.

I really don't want to go back to NPM just cause of this stupid issue.

Edit:
I would love if there's a way to pass values via env variables on how many times the plugin download is retried in case of network issue and how much is the timeout on every retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants