Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing serialNumber passTLSClientCert option to middleware panel #9539

Merged

Conversation

rtribotte
Copy link
Member

@rtribotte rtribotte commented Nov 24, 2022

What does this PR do?

This PR adds the missing serialNumber passTLSClientCert option to the dashboard middleware panel.

Before:
Capture d’écran 2022-11-24 à 12 08 17

After:
Capture d’écran 2022-11-24 à 12 05 38

Motivation

To reflect the middleware configuration in the dashboard.
Related to #9518.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7c72780 into traefik:v2.9 Nov 24, 2022
v2 automation moved this from To review to Done Nov 24, 2022
@rtribotte rtribotte deleted the fix-dashboard-missing-serialnumber-option branch November 24, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants