Add networking example #9542
Merged
Add networking example #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me a while to realize that i have to put the container and traefik in the same network so i thought it should be added to the documentation.
nmengin
added
kind/enhancement
|
Hello @Janik-Haag, Thank you for your contribution. We have moved your network example into the User Guide section to keep a very basic example in the "Quick Start" section. |
mpl
reviewed
Nov 28, 2022
mpl
reviewed
Nov 28, 2022
mpl
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to realize that i have to put the container and traefik in the same network so i thought it should be added to the documentation.
What does this PR do?
Telling people to use a external network with docker containers
Motivation
It took me a while to realize that that's the fault