Handle broken TLS conf better #9572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl
added
area/tls
status/1-needs-design-review
kind/bug/fix
rtribotte
approved these changes
Dec 5, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes sure that when a TLS config (referenced by a router) turns out to be broken, then the route that should have been reached according to this TLS configuration is invalidated, and is therefore unreachable.
The goal is to enforce the user original intent, and to avoid a situation where the route (and the services behind it) stays reachable through another (potentially less secure) TLS configuration.
Motivation
Fixes #9557
More
- [ ] Added/updated documentationAdditional Notes
Co-authored-by: Jean-Baptiste Doumenjou 925513+jbdoumenjou@users.noreply.github.com
Co-authored-by: Romain rtribotte@users.noreply.github.com