Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs of the request #9574

Merged
merged 2 commits into from Dec 5, 2022
Merged

Remove logs of the request #9574

merged 2 commits into from Dec 5, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 5, 2022 •
edited by tomMoulard

What does this PR do?

Removes logs related to dumped requests.

ex:

time="2022-11-30T18:59:08Z" level=debug msg="vulcand/oxy/roundrobin/rr: completed ServeHttp on request" Request="{\"Method\":\"POST\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/<redacted>/<redacted>\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/2.0\",\"ProtoMajor\":2,\"ProtoMinor\":0,\"Header\":{\"Authorization\":[\"Bearer <token value was here>\"],\"Content-Type\":[\"application/grpc\"],\"Grpc-Accept-Encoding\":[\"gzip\"],\"Grpc-Timeout\":[\"29999886u\"],\"Te\":[\"trailers\"],\"User-Agent\":[\"<redacted>\"],<remainder of log message removed>

vulcand/oxy@v1.4.2...d5cb734

Motivation

To not display credentials from headers.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.9 milestone Dec 5, 2022
@ldez ldez added this to To review in v2 via automation Dec 5, 2022
tomMoulard
tomMoulard approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

rtribotte
rtribotte approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

jbdoumenjou
jbdoumenjou approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@traefiker traefiker merged commit 778188e into traefik:v2.9 Dec 5, 2022
v2 automation moved this from To review to Done Dec 5, 2022
@ldez ldez deleted the fix/oxy-log-headers branch December 5, 2022 10:33
@tomMoulard tomMoulard changed the title fix: remove logs of the request Remove logs of the request Dec 7, 2022
@GoVulnBot GoVulnBot mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@tomMoulard tomMoulard tomMoulard approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/logs kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @tomMoulard @rtribotte @traefiker