fix: remove partial dynamic parameters in FE routing

Needed for the react-router update because of [ #9506 - Fix inadvertent support for partial dynamic parameters](remix-run/react-router#9506). JIRA Ticket: MB-15974 Co-authored-by: Kyle Hill <kyle@truss.works>
transcom · Jun 6, 2023 · 18ef91c · 18ef91c
1 parent 0672969
commit 18ef91c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/constants/routes.js b/src/constants/routes.js
@@ -61,8 +61,8 @@ export const servicesCounselingRoutes = {
   MOVE_VIEW_PATH: 'details',
   BASE_ORDERS_EDIT_PATH: `${BASE_COUNSELING_MOVE_PATH}/orders`,
   ORDERS_EDIT_PATH: 'orders',
-  BASE_SHIPMENT_ADD_PATH: `${BASE_COUNSELING_MOVE_PATH}/new-:shipmentType`,
-  SHIPMENT_ADD_PATH: 'new-:shipmentType',
+  BASE_SHIPMENT_ADD_PATH: `${BASE_COUNSELING_MOVE_PATH}/new-shipment/:shipmentType`,
+  SHIPMENT_ADD_PATH: 'new-shipment/:shipmentType',
   BASE_SHIPMENT_EDIT_PATH: `${BASE_COUNSELING_MOVE_PATH}/shipments/:shipmentId`,
   SHIPMENT_EDIT_PATH: 'shipments/:shipmentId',
   BASE_SHIPMENT_ADVANCE_PATH: `${BASE_COUNSELING_MOVE_PATH}/shipments/:shipmentId/advance`,

diff --git a/src/pages/Office/ServicesCounselingMoveInfo/ServicesCounselingMoveInfo.test.jsx b/src/pages/Office/ServicesCounselingMoveInfo/ServicesCounselingMoveInfo.test.jsx
@@ -133,7 +133,7 @@ describe('Services Counseling Move Info Container', () => {
       ['Services Counseling Move Details', '/'],
       ['Services Counseling Move Details', 'details'],
       ['Review Documents', 'shipments/SHIP123/document-review'],
-      ['Services Counseling Add Shipment', 'new-hhg'],
+      ['Services Counseling Add Shipment', 'new-shipment/hhg'],
       ['Services Counselor Customer Support Remarks', 'customer-support-remarks'],
       ['Move History', 'history'],
       ['Services Counseling Move Document Wrapper', 'allowances'],

diff --git a/src/pages/Office/index.test.jsx b/src/pages/Office/index.test.jsx
@@ -206,7 +206,7 @@ describe('Office App', () => {
     it.each([
       ['Move Queue', '/moves/queue', roleTypes.TOO],
       ['Payment Request Queue', '/invoicing/queue', roleTypes.TIO],
-      ['Services Counseling Add Shipment', '/new-PPM', roleTypes.SERVICES_COUNSELOR],
+      ['Services Counseling Add Shipment', '/new-shipment/PPM', roleTypes.SERVICES_COUNSELOR],
       ['Services Counseling Queue', '/counseling', roleTypes.SERVICES_COUNSELOR],
       ['Services Counseling Queue', '/PPM-closeout', roleTypes.SERVICES_COUNSELOR],
       ['Services Counseling Move Info', '/counseling/moves/test123/', roleTypes.SERVICES_COUNSELOR],
@@ -261,7 +261,7 @@ describe('Office App', () => {
     it.each([
       ['Move Queue', '/moves/queue', roleTypes.PRIME_SIMULATOR],
       ['Payment Request Queue', '/invoicing/queue', roleTypes.PRIME_SIMULATOR],
-      ['Services Counseling Add Shipment', '/new-PPM', roleTypes.PRIME_SIMULATOR],
+      ['Services Counseling Add Shipment', '/new-shipment/PPM', roleTypes.PRIME_SIMULATOR],
       ['Services Counseling Move Info', '/counseling/moves/test123/', roleTypes.QAE_CSR],
       ['Edit Shipment Details', '/moves/test123/shipments/ship123', roleTypes.QAE_CSR],
       ['Prime Simulator Move Details', '/simulator/moves/test123/details', roleTypes.QAE_CSR],