Skip to content

Commit

Permalink
@uppy/screen-capture: fix TODOs (#3930)
Browse files Browse the repository at this point in the history
- rename `RecorderScreen` class file to match with the class name.
- rename `Stopwatch` -> `StopWatch` (PascalCase convention).
  • Loading branch information
aduh95 committed Aug 2, 2022
1 parent dc7ad4b commit 386d72d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
@@ -1,4 +1,3 @@
// TODO: rename this file to RecorderScreen.jsx in the next major.
/* eslint-disable react/jsx-props-no-spreading */
import { h, Component } from 'preact'
import RecordButton from './RecordButton.jsx'
Expand Down
4 changes: 2 additions & 2 deletions packages/@uppy/screen-capture/src/ScreenCapture.jsx
Expand Up @@ -2,7 +2,7 @@ import { h } from 'preact'
import { UIPlugin } from '@uppy/core'
import getFileTypeExtension from '@uppy/utils/lib/getFileTypeExtension'
import ScreenRecIcon from './ScreenRecIcon.jsx'
import CaptureScreen from './CaptureScreen.jsx'
import RecorderScreen from './RecorderScreen.jsx'

import packageJson from '../package.json'
import locale from './locale.js'
Expand Down Expand Up @@ -392,7 +392,7 @@ export default class ScreenCapture extends UIPlugin {
}

return (
<CaptureScreen
<RecorderScreen
{...recorderState} // eslint-disable-line react/jsx-props-no-spreading
onStartRecording={this.startRecording}
onStopRecording={this.stopRecording}
Expand Down
5 changes: 2 additions & 3 deletions packages/@uppy/screen-capture/src/StopWatch.jsx
@@ -1,7 +1,6 @@
import { h, Component } from 'preact'

// TODO: rename this class to StopWatch in the next major.
class Stopwatch extends Component {
class StopWatch extends Component {
constructor (props) {
super(props)
this.state = { elapsedTime: 0 }
Expand Down Expand Up @@ -105,4 +104,4 @@ class Stopwatch extends Component {
}
}

export default Stopwatch
export default StopWatch

0 comments on commit 386d72d

Please sign in to comment.