@uppy/store-default: refactor to ESM (#3746)

transloadit · May 17, 2022 · 440f3ae · 440f3ae
1 parent 538c37b
commit 440f3ae
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -220,6 +220,7 @@ module.exports = {
         'packages/@uppy/redux-dev-tools/src/**/*.js',
         'packages/@uppy/screen-capture/src/**/*.js',
         'packages/@uppy/status-bar/src/**/*.js',
+        'packages/@uppy/store-default/src/**/*.js',
         'packages/@uppy/store-redux/src/**/*.js',
         'packages/@uppy/svelte/src/**/*.js',
         'packages/@uppy/svelte/rollup.config.js',

diff --git a/packages/@uppy/store-default/package.json b/packages/@uppy/store-default/package.json
@@ -5,6 +5,7 @@
   "license": "MIT",
   "main": "lib/index.js",
   "types": "types/index.d.ts",
+  "type": "module",
   "keywords": [
     "file uploader",
     "uppy",

diff --git a/packages/@uppy/store-default/src/index.js b/packages/@uppy/store-default/src/index.js
@@ -1,12 +1,13 @@
+import packageJson from '../package.json'
 /**
  * Default store that keeps state in a simple object.
  */
 class DefaultStore {
-  static VERSION = require('../package.json').version
+  static VERSION = packageJson.version
 
   constructor () {
     this.state = {}
-    this.callbacks = []
+    this.callbacks = [] // TODO: use a Set instead, make it a private prop
   }
 
   getState () {
@@ -39,6 +40,7 @@ class DefaultStore {
   }
 }
 
-module.exports = function defaultStore () {
+// TODO: export the class instead in the next major.
+export default function defaultStore () {
   return new DefaultStore()
 }
diff --git a/packages/@uppy/store-default/src/index.test.js b/packages/@uppy/store-default/src/index.test.js
@@ -1,4 +1,4 @@
-const DefaultStore = require('./index')
+import DefaultStore from './index.js'
 
 describe('DefaultStore', () => {
   it('can be created with or without new', () => {