Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set meta based on drop target event #2973

Closed
wants to merge 5 commits into from
Closed

Set meta based on drop target event #2973

wants to merge 5 commits into from

Commits on Jun 16, 2021

  1. Added new option activeClass for customizing the class added to targe… 

    …t on dragover.

Added new option setMeta to enable setting specific meta fields depending on the drop event. This enables using one DropTarget with body as target with the meta fields being set depending on which DOM element the files was dropped.
    @tobiasps
    tobiasps committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    6500a19 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Merge branch 'main' into drag-target-improvements

    @tobiasps
    tobiasps committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    d815173 View commit details
    Browse the repository at this point in the history

  2. Update packages/@uppy/drop-target/src/index.js 

    Simplify adding meta fields from setMeta in addFiles function.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @tobiasps @aduh95
    tobiasps and aduh95 committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    164ef72 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Simplify addFiles by reverting to old code with the `...this.setMeta?… 

    ….(file, event)` added.
    @tobiasps
    tobiasps committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    07a3d2d View commit details
    Browse the repository at this point in the history

  2. Update packages/@uppy/drop-target/types/index.d.ts 

    Allow setMeta to be optional.
Using more descriptive type for the setMeta option.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @tobiasps @aduh95
    tobiasps and aduh95 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    263ca8d View commit details
    Browse the repository at this point in the history