Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close window on auth callback error and show error to user #3143

Merged
merged 16 commits into from Sep 30, 2021
Merged

Close window on auth callback error and show error to user #3143

merged 16 commits into from Sep 30, 2021

Commits on Aug 29, 2021

  1. Close window on auth callback error 

    Because simply receiving a "Bad request" is very bad UX
For example if the user cancels the auth flow, or doesn't give companion access
it's better to go back
    @mifi
    mifi committed Aug 29, 2021
    Copy the full SHA
    45b737c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Update packages/@uppy/companion/src/server/controllers/callback.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mifi @aduh95
    mifi and aduh95 committed Aug 30, 2021
    Copy the full SHA
    4d168f9 View commit details
    Browse the repository at this point in the history

  2. Update packages/@uppy/companion/src/server/controllers/callback.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mifi @aduh95
    mifi and aduh95 committed Aug 30, 2021
    Copy the full SHA
    fe300c4 View commit details
    Browse the repository at this point in the history

  3. Update packages/@uppy/companion/src/server/controllers/callback.js

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    79e8618 View commit details
    Browse the repository at this point in the history

  4. Update callback.js

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    a668782 View commit details
    Browse the repository at this point in the history

  5. pull out reusable code to getDynamicStateFromRequest

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    7647045 View commit details
    Browse the repository at this point in the history

  6. Signal auth error to client

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    40bbfed View commit details
    Browse the repository at this point in the history

  7. fix test mocking

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    98263cf View commit details
    Browse the repository at this point in the history

  8. npm run build:locale-pack

    @mifi
    mifi committed Aug 30, 2021
    Copy the full SHA
    ac13a68 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Update packages/@uppy/companion/src/server/controllers/callback.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mifi @aduh95
    mifi and aduh95 committed Aug 31, 2021
    Copy the full SHA
    c1f6645 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @mifi
    mifi committed Aug 31, 2021
    Copy the full SHA
    8b2fc95 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Merge branch 'main' into improve-callback-error

    @mifi
    mifi committed Sep 30, 2021
    Copy the full SHA
    89a8ff1 View commit details
    Browse the repository at this point in the history

  2. add i18n string that got lost during merge

    @mifi
    mifi committed Sep 30, 2021
    Copy the full SHA
    d528b19 View commit details
    Browse the repository at this point in the history

  3. add french translation

    @mifi
    mifi committed Sep 30, 2021
    Copy the full SHA
    010129a View commit details
    Browse the repository at this point in the history

  4. add dutch translation

    @mifi
    mifi committed Sep 30, 2021
    Copy the full SHA
    ef62ead View commit details
    Browse the repository at this point in the history

  5. add norwegian translation

    @mifi
    mifi committed Sep 30, 2021
    Copy the full SHA
    25a0586 View commit details
    Browse the repository at this point in the history