Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make uploadUrls recommended #3182

Merged
merged 4 commits into from Sep 30, 2021
Merged

Make uploadUrls recommended #3182

merged 4 commits into from Sep 30, 2021

Commits on Sep 9, 2021

  1. Make uploadUrls recommended 

    - warn on startup if uploadUrls is not specified as not specifying it is a security risk
- improve docs to make it more clear why uploadUrls should be specified (say that uploadUrls is required even though it is not, due to backward compatibility)
- no longer require_tld (it gives a false security) - fixes #2831
    @mifi
    mifi committed Sep 9, 2021
    Copy the full SHA
    f570748 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @mifi
    mifi committed Sep 9, 2021
    Copy the full SHA
    108d4de View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mifi @aduh95
    mifi and aduh95 committed Sep 10, 2021
    Copy the full SHA
    85aec7c View commit details
    Browse the repository at this point in the history

  2. remove example: []

    @mifi
    mifi committed Sep 10, 2021
    Copy the full SHA
    157f6c2 View commit details
    Browse the repository at this point in the history