New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @uppy/unsplash
production ready
#3196
Conversation
- Pass author data in companion - Show author on hover - SHow author always for touch devices
…nsplash * 'unsplash' of https://github.com/transloadit/uppy: Always show underline in artist link to indicate it is a link
@nqst note that the video shows the underline on hover but I now changed it to be always present. This better indicates it's a link, not a label. |
I think I liked the first version more: when there's an immediate underline, it draws more attention to the author name than before — while it's better to keep that attention on the photos, so that it's easier to select them without distractions. What do you think? |
Update: we need to add attribution in other places of the UI as well. This will require some refactoring first. The PR will get big but I'll reference the individual commits with the changes that matter. |
* main: Show all details on mobile when `showProgressDetails` is `true` (#3174) @uppt/xhr-upload: fix `this.uppy is undefined` error (#3207) ci: test on Node.js v16.x (#3205) @uppy/dashboard: fix linter (#3206) Add `2.1.1` to `CHANGELOG.md` Release Release Fix "attempted to use private field on non-instance" in `SearchProvider` (#3201) Add 'done' to `nb_NO.js` (#3200) @uppy/transloadit: fix unhandledPromiseRejection failures (#3197) fix: AbortController is not defined on Node.js (Server Side Render) (#3169)
I added author attribution to the dashboard file overview (6c2a4c3). I made sure the file name always gets truncated to fit on one line so the second line is always the author link, which is also truncated to fit on that line only. This is the design I came up with. Feel free to provide feedback on it. |
Haven’t tested locally, but watched the video and screenshots, very well done on the implementation, I really like it! Also kudos for passing the name along in |
packages/@uppy/dashboard/src/components/FileItem/FileInfo/index.js
Outdated
Show resolved
Hide resolved
packages/@uppy/dashboard/src/components/FileItem/FileInfo/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
…nsplash * 'unsplash' of https://github.com/transloadit/uppy: Apply suggestions from code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Alexander Zaytsev <nqst@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes #3175
Fixes #2635
Fixes #2772
You can use the referenced commits to view the changes for the feature/fix without the refactor noise
docs/unsplash.md
Screen.Recording.2021-09-14.at.17.11.49.mov
Todo:
?utm_source=your_app_name&utm_medium=referral
)