Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/image-editor: add workaround for when Cropper is loaded as ESM #3218

Merged
merged 3 commits into from Sep 28, 2021
Merged

@uppy/image-editor: add workaround for when Cropper is loaded as ESM #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ded2978
@uppy/image-editor: add workaround for when `Cropper` is loaded as ESM
aduh95 Sep 21, 2021
fcb76e2
Update packages/@uppy/image-editor/src/Editor.js
aduh95 Sep 23, 2021
5ab2d81
Add backlog entry
aduh95 Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions BACKLOG.md
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@ PRs are welcome! Please do open an issue to discuss first if it's a big feature,
## `3.0.0`

- [ ] Switch to ES Modules (ESM)
- [ ] @uppy/image-editor: Remove silly hack to work around non-ESM.

## `4.0.0`

Expand Down
6 changes: 5 additions & 1 deletion packages/@uppy/image-editor/src/Editor.js
View file
Open in desktop
@@ -1,6 +1,10 @@
const Cropper = require('cropperjs')
const CropperImport = require('cropperjs')
const { h, Component } = require('preact')

// @TODO A silly hack that we can get rid of when moving to ESM.
// eslint-disable-next-line no-underscore-dangle
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
const Cropper = CropperImport.__esModule ? CropperImport.default : CropperImport

module.exports = class Editor extends Component {
constructor (props) {
super(props)
Expand Down