Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish master->main job #3315

Merged
merged 1 commit into from Nov 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/aws-presigned-url/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/transloadit-textarea/index.html
Expand Up @@ -105,7 +105,7 @@ <h1>Markdown Bin</h1>
</header>
<main>
<p>
Markdown Bin is a demo app that works a bit like Github Gists or pastebin. You can add markdown snippets, and add file attachments to each snippet by clicking "Upload an attachment" or by dragging files onto the text area. Transloadit generates an inline preview image for images, videos, and audio files. <a target="_blank" href="https://github.com/transloadit/uppy/blob/master/examples/transloadit-textarea/template.json">&raquo;&nbsp;View the Assembly Template here.</a>
Markdown Bin is a demo app that works a bit like Github Gists or pastebin. You can add markdown snippets, and add file attachments to each snippet by clicking "Upload an attachment" or by dragging files onto the text area. Transloadit generates an inline preview image for images, videos, and audio files. <a target="_blank" href="https://github.com/transloadit/uppy/blob/main/examples/transloadit-textarea/template.json">&raquo;&nbsp;View the Assembly Template here.</a>
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion examples/transloadit/index.html
Expand Up @@ -29,7 +29,7 @@
<main>
<h1>Robodog <img src="https://transloadit.edgly.net/assets/images/logo-small.svg" alt="Transloadit" id="logo"> playground</h1>
<p>
This page contains small examples for every API offered by the Robodog library. Please see the <a href="https://github.com/transloadit/uppy/tree/master/examples/transloadit">Github repository</a> for the source code.
This page contains small examples for every API offered by the Robodog library. Please see the <a href="https://github.com/transloadit/uppy/tree/main/examples/transloadit">Github repository</a> for the source code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use HEAD instead of main in case we change the default branch name again (however unlikely it is)?

Suggested change
This page contains small examples for every API offered by the Robodog library. Please see the <a href="https://github.com/transloadit/uppy/tree/main/examples/transloadit">Github repository</a> for the source code.
This page contains small examples for every API offered by the Robodog library. Please see the <a href="https://github.com/transloadit/uppy/tree/HEAD/examples/transloadit">Github repository</a> for the source code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no git expert, so I don't know if there are any drawbacks of using HEAD instead of main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goto-bus-stop @kvz HEAD vs main?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a lot of places where we reference main now so only changing it here wouldn't help much if we change the branch name again. We can leave it as is in my opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a lot of places where we reference main now so only changing it here wouldn't help much if we change the branch name again.

I think the idea if someone was copying the link to somewhere else (StackOverflow, a documentation, etc.), they would copy HEAD instead of main, and the link would not break if we ever change the default branch name again. It's still a very low probability anyway, so I don't feel strongly about it.


<hr>
<h2>robodog.form()</h2>
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/angular/README.md
Expand Up @@ -2,7 +2,7 @@

<img src="https://uppy.io/images/logos/uppy-dog-head-arrow.svg" width="120" alt="Uppy logo: a superman puppy in a pink suit" align="right">

<a href="https://www.npmjs.com/package/@uppy/angular"><img src="https://img.shields.io/npm/v/@uppy/angular.svg?style=flat-square"></a> <a href="https://travis-ci.org/transloadit/uppy"><img src="https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square" alt="Build Status"></a>
<a href="https://www.npmjs.com/package/@uppy/angular"><img src="https://img.shields.io/npm/v/@uppy/angular.svg?style=flat-square"></a> <a href="https://travis-ci.org/transloadit/uppy"><img src="https://img.shields.io/travis/transloadit/uppy/main.svg?style=flat-square" alt="Build Status"></a>

Angular component wrappers around Uppy’s officially maintained UI plugins.

Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/companion/README.md
Expand Up @@ -2,7 +2,7 @@

<img src="http://uppy.io/images/logos/uppy-dog-full.svg" width="120" alt="Uppy logo — a superman puppy in a pink suit" align="right">

[![Build Status](https://travis-ci.org/transloadit/uppy.svg?branch=master)](https://travis-ci.org/transloadit/uppy)
[![Build Status](https://travis-ci.org/transloadit/uppy.svg?branch=main)](https://travis-ci.org/transloadit/uppy)

Companion is a server integration for [Uppy](https://github.com/transloadit/uppy) file uploader.

Expand Down
8 changes: 4 additions & 4 deletions packages/@uppy/companion/test/__tests__/companion.js
Expand Up @@ -133,12 +133,12 @@ describe('validate upload data', () => {
})
})

describe('handle master oauth redirect', () => {
const serverWithMasterOauth = getServer({
describe('handle main oauth redirect', () => {
const serverWithMainOauth = getServer({
COMPANION_OAUTH_DOMAIN: 'localhost:3040',
})
test('redirect to a valid uppy instance', () => {
return request(serverWithMasterOauth)
return request(serverWithMainOauth)
.get(`/dropbox/redirect?state=${OAUTH_STATE}`)
.set('uppy-auth-token', token)
.expect(302)
Expand All @@ -147,7 +147,7 @@ describe('handle master oauth redirect', () => {

test('do not redirect to invalid uppy instances', () => {
const state = 'state-with-invalid-instance-url' // see mock ../../src/server/helpers/oauth-state above
return request(serverWithMasterOauth)
return request(serverWithMainOauth)
.get(`/dropbox/redirect?state=${state}`)
.set('uppy-auth-token', token)
.expect(400)
Expand Down
Expand Up @@ -125,7 +125,7 @@ describe('Test Provider options', () => {
expect(grantConfig.zoom.secret).toBeUndefined()
})

test('sets a master redirect uri, if oauthDomain is set', () => {
test('sets a main redirect uri, if oauthDomain is set', () => {
companionOptions.server.oauthDomain = 'domain.com'
providerManager.addProviderOptions(companionOptions, grantConfig)

Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/locales/README.md
Expand Up @@ -7,7 +7,7 @@
![CI status for Companion tests](https://github.com/transloadit/uppy/workflows/Companion/badge.svg)
![CI status for browser tests](https://github.com/transloadit/uppy/workflows/End-to-end%20tests/badge.svg)

This package includes all the locale packs that you can use to make Uppy speak your language! If your language is missing, please consider [contributing](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/locales/src), starting with `en_US`, which is always up-to-date automatically.
This package includes all the locale packs that you can use to make Uppy speak your language! If your language is missing, please consider [contributing](https://github.com/transloadit/uppy/tree/main/packages/%40uppy/locales/src), starting with `en_US`, which is always up-to-date automatically.

## Installation

Expand Down
2 changes: 1 addition & 1 deletion test/endtoend/url-plugin/test.js
Expand Up @@ -12,7 +12,7 @@ describe('File upload with URL plugin', () => {
// import set url value
const urlInput = await browser.$('input.uppy-Url-input')
await urlInput.waitForDisplayed(3000)
await urlInput.setValue('https://github.com/transloadit/uppy/raw/master/assets/palette.png')
await urlInput.setValue('https://github.com/transloadit/uppy/raw/main/assets/palette.png')
const importButton = await browser.$('button.uppy-Url-importButton')
await importButton.click()

Expand Down
2 changes: 1 addition & 1 deletion website/inject.js
Expand Up @@ -225,7 +225,7 @@ function injectLocaleList () {
const regionName = regionalDisplayNames.of(regionCode)
const npmPath = `<code class="raw"><a href="https://www.npmjs.com/package/@uppy/locales">@uppy/locales</a>/lib/${localeName}</code>`
const cdnPath = `[\`${localeName}.min.js\`](https://releases.transloadit.com/uppy/locales/v${localePackageVersion}/${localeName}.min.js)`
const githubSource = `[\`${localeName}.js\`](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/locales/src/${localeName}.js)`
const githubSource = `[\`${localeName}.js\`](https://github.com/transloadit/uppy/blob/main/packages/%40uppy/locales/src/${localeName}.js)`
const mdTableRow = `| ${languageName}<br/> <small>${regionName}</small>${variant ? `<br /><small>(${variant})</small>` : ''} | ${npmPath} | ${cdnPath} | ✏️ ${githubSource} |`
mdRows.push(mdTableRow)

Expand Down
8 changes: 4 additions & 4 deletions website/src/docs/companion.md
Expand Up @@ -13,7 +13,7 @@ Drag and drop, webcam, basic file manipulation (adding metadata, for example) an

<!--retext-simplify ignore however-->

However, if you add [Companion](https://github.com/transloadit/uppy/tree/master/packages/@uppy/companion) to the mix, your users will be able to select files from remote sources, such as Instagram, Google Drive and Dropbox, bypassing the client (so a 5 GB video isn’t eating into your users’ data plans), and then uploaded to the final destination. Files are removed from Companion after an upload is complete, or after a reasonable timeout. Access tokens also don’t stick around for long, for security reasons.
However, if you add [Companion](https://github.com/transloadit/uppy/tree/main/packages/@uppy/companion) to the mix, your users will be able to select files from remote sources, such as Instagram, Google Drive and Dropbox, bypassing the client (so a 5 GB video isn’t eating into your users’ data plans), and then uploaded to the final destination. Files are removed from Companion after an upload is complete, or after a reasonable timeout. Access tokens also don’t stick around for long, for security reasons.

Companion handles the server-to-server communication between your server and file storage providers such as Google Drive, Dropbox, Instagram, etc. Note that you can **not** upload files **to** Companion, it only handles the third party integrations.

Expand Down Expand Up @@ -250,7 +250,7 @@ export COMPANION_STREAMING_UPLOAD=true
export COMPANION_MAX_FILE_SIZE="100000000"
```

See [env.example.sh](https://github.com/transloadit/uppy/blob/master/env.example.sh) for an example configuration script.
See [env.example.sh](https://github.com/transloadit/uppy/blob/main/env.example.sh) for an example configuration script.

### Options

Expand Down Expand Up @@ -419,7 +419,7 @@ app.use(uppy.app({

### Running in Kubernetes

We have [a detailed guide on running Companion in Kubernetes](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/KUBERNETES.md) for you, that’s how we run our example server at <https://companion.uppy.io>.
We have [a detailed guide on running Companion in Kubernetes](https://github.com/transloadit/uppy/blob/main/packages/%40uppy/companion/KUBERNETES.md) for you, that’s how we run our example server at <https://companion.uppy.io>.

### Adding custom providers

Expand Down Expand Up @@ -575,7 +575,7 @@ This would get the Companion instance running on `http://localhost:3020`. It use

## Live example

An example server is running at <https://companion.uppy.io>, which is deployed with [Kubernetes](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/KUBERNETES.md)
An example server is running at <https://companion.uppy.io>, which is deployed with [Kubernetes](https://github.com/transloadit/uppy/blob/main/packages/%40uppy/companion/KUBERNETES.md)

## How the Authentication and Token mechanism works

Expand Down
2 changes: 1 addition & 1 deletion website/src/docs/locales.md
Expand Up @@ -79,7 +79,7 @@ uppy.use(DragDrop, {

If you speak a language we don’t yet support, you can contribute! Here’s how you do it:

1. Go to the [uppy/locales](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/locales/src) directory in the Uppy GitHub repo.
1. Go to the [uppy/locales](https://github.com/transloadit/uppy/tree/main/packages/%40uppy/locales/src) directory in the Uppy GitHub repo.
2. Go to `en_US.js` and copy its contents, as English is the most up-to-date locale.
3. Press “Create new file”, name it according to the [`language_COUNTRY` format](http://www.i18nguy.com/unicode/language-identifiers.html), make sure to use underscore `_` as a divider. Examples: `en_US`, `en_GB`, `ru_RU`, `ar_AE`. Variants should be trailing, for example `sr_RS_Latin` for Serbian Latin vs Cyrillic.
4. If your language has different pluralization rules than English, update the `pluralize` implementation. If you are unsure how to do this, please ask us for help in a [GitHub issue](https://github.com/transloadit/uppy/issues/new).
Expand Down
2 changes: 1 addition & 1 deletion website/src/docs/providers.md
Expand Up @@ -6,7 +6,7 @@ order: 10
category: "Sources"
---

The Provider plugins help you connect to your accounts with remote file providers such as [Dropbox](https://dropbox.com), [Google Drive](https://drive.google.com), [Instagram](https://instagram.com) and remote URLs (importing a file by pasting a direct link to it). Because this requires server-to-server communication, they work tightly with [Companion](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion) to manage the server-to-server authorization for your account. Almost all the communication (file download/upload) is done on the server-to-server end, so this saves you the stress and bills of data consumption on the client.
The Provider plugins help you connect to your accounts with remote file providers such as [Dropbox](https://dropbox.com), [Google Drive](https://drive.google.com), [Instagram](https://instagram.com) and remote URLs (importing a file by pasting a direct link to it). Because this requires server-to-server communication, they work tightly with [Companion](https://github.com/transloadit/uppy/tree/main/packages/%40uppy/companion) to manage the server-to-server authorization for your account. Almost all the communication (file download/upload) is done on the server-to-server end, so this saves you the stress and bills of data consumption on the client.

As of now, the supported providers are [**Dropbox**](/docs/dropbox), [**Google Drive**](/docs/google-drive), [**OneDrive**](/docs/onedrive/), [**Box**](/docs/box/), [**Instagram**](/docs/instagram), [**Facebook**](/docs/facebook/), [**Zoom**](/docs/zoom/) and [**URL**](/docs/url).

Expand Down
2 changes: 1 addition & 1 deletion website/src/docs/react-native.md
Expand Up @@ -11,7 +11,7 @@ category: "React"

`@uppy/react-native` is a basic Uppy component for React Native with Expo. This plugin is still in development, and is not fully featured. You can select local images or videos, take pictures with a camera or add any files from [remote urls](/docs/url) with the help of a server-side component, [Uppy Companion](/docs/companion).

Make sure to check out the example in [examples/react-native-expo](https://github.com/transloadit/uppy/tree/master/examples/react-native-expo).
Make sure to check out the example in [examples/react-native-expo](https://github.com/transloadit/uppy/tree/main/examples/react-native-expo).

<img width="400" src="/images/2019-04-11-react-native-ui-1.png">

Expand Down
2 changes: 1 addition & 1 deletion website/src/docs/stores.md
Expand Up @@ -137,4 +137,4 @@ function defaultStore () {

A pattern like this, where users can pass options via a function call if necessary, is recommended.

See the [@uppy/store-default](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/store-default) package for more inspiration.
See the [@uppy/store-default](https://github.com/transloadit/uppy/tree/main/packages/%40uppy/store-default) package for more inspiration.
2 changes: 1 addition & 1 deletion website/src/docs/svelte.md
Expand Up @@ -25,7 +25,7 @@ yarn add @uppy/svelte

Make sure to also include the necessary CSS files for each Uppy Svelte component you are using.

For [the example](https://github.com/transloadit/uppy/tree/master/examples/svelte-example), we used `svelte-preprocess` and `postcss` to allow imports in CSS. Here is a basic guide for getting that configured with Rollup.
For [the example](https://github.com/transloadit/uppy/tree/main/examples/svelte-example), we used `svelte-preprocess` and `postcss` to allow imports in CSS. Here is a basic guide for getting that configured with Rollup.

```shell
npm install -D postcss postcss-import postcss-load-config
Expand Down
2 changes: 1 addition & 1 deletion website/src/examples/markdown-snippets/index.ejs
Expand Up @@ -11,7 +11,7 @@ This is a demo app that works a bit like Github Gists or Pastebin. You can add m

Uppy <a href="/docs/robodog/">Robodog</a> (using <a href="https://transloadit.com">Transloadit</a> internally) generates an inline preview image for images, videos, and audio files.

You can view the <a target="_blank" href="https://github.com/transloadit/uppy/blob/master/examples/transloadit-textarea/template.json">Transloadit Assembly Template</a> and the <a href="#snippet-example-code"> code for this demo</a>.
You can view the <a target="_blank" href="https://github.com/transloadit/uppy/blob/main/examples/transloadit-textarea/template.json">Transloadit Assembly Template</a> and the <a href="#snippet-example-code"> code for this demo</a>.
{% endblockquote %}

<p>
Expand Down
10 changes: 5 additions & 5 deletions website/themes/uppy/layout/example.ejs
Expand Up @@ -12,12 +12,12 @@
is actively developed and the example section
is our playground. Things might not work, but we're working hard to improve.</p>
<p>We're on a monthly release cycle and our latest version is
<a href="https://github.com/transloadit/uppy/blob/master/CHANGELOG.md#<%- theme.uppy_version_anchor %>">v<%- theme.uppy_version %></a>,
but the example pages reflect the latest work in our master branch. Here's
<a href="https://github.com/transloadit/uppy/compare/uppy@<%- theme.uppy_version %>...master">what changed in master since v<%- theme.uppy_version %></a>
<a href="https://github.com/transloadit/uppy/blob/main/CHANGELOG.md#<%- theme.uppy_version_anchor %>">v<%- theme.uppy_version %></a>,
but the example pages reflect the latest work in our main branch. Here's
<a href="https://github.com/transloadit/uppy/compare/uppy@<%- theme.uppy_version %>...main">what changed in main since v<%- theme.uppy_version %></a>
in terms of commits, while the CHANGELOG
provides a higher level view of the things planned for our
<a href="https://github.com/transloadit/uppy/blob/master/CHANGELOG.md#next">next release</a>.</p>
<a href="https://github.com/transloadit/uppy/blob/main/CHANGELOG.md#next">next release</a>.</p>

<!-- Add textarea already so it's available immediately for logging.
It is later made visible, and moved into the #console-wrapper to position it in layout how
Expand Down Expand Up @@ -69,6 +69,6 @@
</script>

<div class="footer">Caught a mistake or want to contribute to the documentation?
<a href="https://github.com/transloadit/uppy/blob/master/website/src/<%- page.source %>" rel="noreferrer noopener" target="_blank">Edit/fork this page directly on Github</a>!
<a href="https://github.com/transloadit/uppy/blob/main/website/src/<%- page.source %>" rel="noreferrer noopener" target="_blank">Edit/fork this page directly on Github</a>!
</div>
</div>
2 changes: 1 addition & 1 deletion website/themes/uppy/layout/page.ejs
Expand Up @@ -21,6 +21,6 @@
</div>
<% } %>
<div class="footer">Caught a mistake or want to contribute to the documentation?
<a href="https://github.com/transloadit/uppy/blob/master/website/src/<%- page.source %>" rel="noreferrer noopener" target="_blank">Edit/fork this page directly on Github</a>!
<a href="https://github.com/transloadit/uppy/blob/main/website/src/<%- page.source %>" rel="noreferrer noopener" target="_blank">Edit/fork this page directly on Github</a>!
</div>
</div>