Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/companion: fix deploy Yarn version #3327

Merged
merged 2 commits into from Nov 29, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/update-yarn.sh
Expand Up @@ -21,7 +21,9 @@ PLUGINS=$(awk '{ if ($1 == "spec:") print $2 }' .yarnrc.yml)
echo "$PLUGINS" | xargs -n1 -t corepack yarn plugin remove
aduh95 marked this conversation as resolved.
Show resolved Hide resolved

cp package.json .yarn/cache/tmp.package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how nice it is to use yarn's cache dir, but probably they will never put a file tmp.package.json file there, but you never know 😄

sed "s#yarn\": \"$CURRENT_VERSION\"#yarn\": \"$LAST_VERSION\"#;s#\"yarn@$CURRENT_VERSION\"#\"yarn@$LAST_VERSION\"#" .yarn/cache/tmp.package.json > package.json
sed "s#\"yarn\": \"$CURRENT_VERSION\"#\"yarn\": \"$LAST_VERSION\"#;s#\"yarn@$CURRENT_VERSION\"#\"yarn@$LAST_VERSION\"#" .yarn/cache/tmp.package.json > package.json
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
cp packages/@uppy/companion/package.json .yarn/cache/tmp.package.json
sed "s#\"yarn\": \"$CURRENT_VERSION\"#\"yarn\": \"$LAST_VERSION\"#;s#\"yarn@$CURRENT_VERSION\"#\"yarn@$LAST_VERSION\"#" .yarn/cache/tmp.package.json > packages/@uppy/companion/package.json
rm .yarn/cache/tmp.package.json

echo "$PLUGINS" | xargs -n1 -t corepack yarn plugin import
Expand Down
4 changes: 3 additions & 1 deletion packages/@uppy/companion/package.json
Expand Up @@ -112,7 +112,9 @@
"test": "bash -c 'source env.test.sh && ../../../node_modules/jest/bin/jest.js'",
"test:watch": "yarn test -- --watch"
},
"packageManager": "yarn@3.1.0",
"engines": {
"node": ">=10.20.1"
"node": ">=10.20.1",
"yarn": "3.1.0"
}
}