Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: force use of @babel/plugin-proposal-optional-chaining #3335

Merged
merged 1 commit into from Nov 30, 2021
Merged

build: force use of @babel/plugin-proposal-optional-chaining #3335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion babel.config.js
View file
Open in desktop
Expand Up @@ -7,7 +7,10 @@ module.exports = (api) => {
return {
presets: [
['@babel/preset-env', {
include: ['@babel/plugin-proposal-nullish-coalescing-operator'],
include: [
'@babel/plugin-proposal-nullish-coalescing-operator',
'@babel/plugin-proposal-optional-chaining',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@babel/plugin-proposal-optional-chaining',
'@babel/plugin-proposal-optional-chaining', // can be removed in a future semver-major. See https://github.com/transloadit/uppy/pull/3335

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both plugins would be removed, both features are supported in all supported browsers.

],
loose: true,
targets,
useBuiltIns: false, // Don't add polyfills automatically.
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -42,6 +42,7 @@
"@babel/eslint-parser": "^7.11.3",
"@babel/eslint-plugin": "^7.11.3",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.14.5",
"@babel/plugin-proposal-optional-chaining": "^7.16.0",
"@babel/plugin-transform-react-jsx": "^7.10.4",
"@babel/preset-env": "^7.14.7",
"@babel/register": "^7.10.5",
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -42265,6 +42265,7 @@ hexo-filter-github-emojis@arturi/hexo-filter-github-emojis:
"@babel/eslint-parser": ^7.11.3
"@babel/eslint-plugin": ^7.11.3
"@babel/plugin-proposal-nullish-coalescing-operator": ^7.14.5
"@babel/plugin-proposal-optional-chaining": ^7.16.0
"@babel/plugin-transform-react-jsx": ^7.10.4
"@babel/preset-env": ^7.14.7
"@babel/register": ^7.10.5
Expand Down