Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save meta fields when opening the image editor #3339

Merged
merged 3 commits into from Dec 7, 2021
Merged

Save meta fields when opening the image editor #3339

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30888f7
Save meta fields on opening editor
Murderlon Dec 2, 2021
c171458
Add comment
Murderlon Dec 7, 2021
b3e41d1
Fix lint error
Murderlon Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/@uppy/dashboard/src/components/FileCard/index.js
View file
Open in desktop
Expand Up @@ -152,7 +152,14 @@ class FileCard extends Component {
<button
type="button"
className="uppy-u-reset uppy-c-btn uppy-Dashboard-FileCard-edit"
onClick={() => this.props.openFileEditor(file)}
onClick={(event) => {
// When opening the image editor we want to save any meta fields changes.
// Otherwise it's confusing for the user to click save in the editor,
// but the changes here are discarded. This bypasses validation,
// but we are okay with that.
this.handleSave(event)
this.props.openFileEditor(file)
}}
form={this.form.id}
>
{this.props.i18n('editFile')}
Expand Down