Release: uppy@3.0.0-beta.5 #3990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…3947) * Fix Compressor being broken when no name is in the compressed blob * Update packages/@uppy/compressor/src/index.js Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
`webkitGetAsEntry` is a non-standard/deprecated API, replacing it with `getAsFileSystemHandle` when available. This also work around a Chromium bug with symlinks. Fixes: #3505.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Artur Paikin <artur@arturpaikin.com>
… obj (#3951) * core validateRestrictions: return error directly vs the result/reason obj * Refacrtor to actually use restrictionError instead of {reason, message} * Return error instead of throwing
The `#uploadParts` function calls itself after any part is uploaded. It also determines which new chunks to upload based on their `state.busy` value. This introduced a race condition, as `state.busy` was being set to false in the XHR event handlers. So if one part were to complete while another part had finished the XHR request, but not yet completed, then an upload for that second part would be started again, despite the fact that the previous upload was still in progress. Multiple uploads for the same part at the same time cause numerous issues, and should never happen. This is especially noticeable when an XHR request fails. `#uploadPart` is wrapped in `#retryable`, so the part will be retried, however, for the entire `retryDelay`, the chunk's `state.busy` value would be false, meaning that if any other part completed, this part would be uploaded again, despite the fact that the upload is already ongoing. To fix this, this commit moves setting `state.busy` to the `before` and `after` functions of the `#retryable` call, so a part will remain `busy` for the entire time it is being uploaded/retried.
* Update CONTRIBUTING.md * Update CONTRIBUTING.md
…Core (#3982) * Remove deprecated get state and allowMultipleUploads option in Core * Fix tests? * core.getState()
* rewrite to async * rewrite box and dropbox to got (not yet working due to jest esm issues) * downgrade got * update developer notes * rewrite - rewrite remaining providers to got - rewrite to async/await - pull out adapt code into adapters - provider/companion tests still todo * add zoom to dev dashboard * rewrites - rewrite remaining providers to got and reuse code - port tests - remove request - remove purest - rewrite periodic ping job to got - rewrite uploader to got - rewrite "url" to got - rewrite getRedirectEvaluator/request to got - rewrite http/https agent/request to got - rewrite credentials.js to got - fix "todo: handle failures differently to return 400 for this case instead" - add test for http/https agent - improve test for credentials (remote/local) - make /zoom/logout return 424 instead of 500 on credentials error - remove useless http-agent tests - fix various eslint warnings * work around ts error * remove forgotten change
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Merlijn Vos <merlijn@soverin.net>
This is a release candidate for the following packages: - `@uppy/angular`: 0.3.1 -> 1.0.0-beta.1 - `@uppy/audio`: 1.0.0-beta.1 -> 1.0.0-beta.2 - `@uppy/aws-s3`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/aws-s3-multipart`: 3.0.0-beta.3 -> 3.0.0-beta.4 - `@uppy/box`: 2.0.0-beta.1 -> 2.0.0-beta.2 - `@uppy/companion`: 4.0.0-beta.3 -> 4.0.0-beta.4 - `@uppy/companion-client`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/compressor`: 1.0.0-beta.2 -> 1.0.0-beta.3 - `@uppy/core`: 3.0.0-beta.3 -> 3.0.0-beta.4 - `@uppy/dashboard`: 3.0.0-beta.3 -> 3.0.0-beta.4 - `@uppy/drag-drop`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/drop-target`: 2.0.0-beta.2 -> 2.0.0-beta.3 - `@uppy/dropbox`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/facebook`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/file-input`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/form`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/golden-retriever`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/google-drive`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/image-editor`: 2.0.0-beta.2 -> 2.0.0-beta.3 - `@uppy/informer`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/instagram`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/locales`: 3.0.0-beta.3 -> 3.0.0-beta.4 - `@uppy/onedrive`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/progress-bar`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/provider-views`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/react`: 3.0.0-beta.3 -> 3.0.0-beta.4 - `@uppy/redux-dev-tools`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/remote-sources`: 1.0.0-beta.3 -> 1.0.0-beta.4 - `@uppy/screen-capture`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/status-bar`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/store-default`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/store-redux`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/svelte`: 2.0.0-beta.1 -> 2.0.0-beta.2 - `@uppy/thumbnail-generator`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/transloadit`: 3.0.0-beta.4 -> 3.0.0-beta.5 - `@uppy/tus`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/unsplash`: 3.0.0-beta.1 -> 3.0.0-beta.2 - `@uppy/url`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/utils`: 5.0.0-beta -> 5.0.0-beta.1 - `@uppy/vue`: 1.0.0-beta.1 -> 1.0.0-beta.2 - `@uppy/webcam`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/xhr-upload`: 3.0.0-beta.2 -> 3.0.0-beta.3 - `@uppy/zoom`: 2.0.0-beta.1 -> 2.0.0-beta.2 - `uppy`: 3.0.0-beta.4 -> 3.0.0-beta.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#uploadParts(Morgan Zolob / @uppy/aws-s3-multipart: Fix race condition in#uploadParts#3955)wsversion (Antoine du Hamel / @uppy/companion: upgradewsversion #3949)getDroppedFiles(Antoine du Hamel / @uppy/utils: modernizegetDroppedFiles#3534)abortMultipartUpload(Antoine du Hamel / @uppy/aws-s3-multipart: ignore exception insideabortMultipartUpload#3950)isobjectfrom dependencies (Antoine du Hamel / @uppy/companion: removeisobjectfrom dependencies #3948)