Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release website fixes #4038

Merged
merged 1 commit into from Aug 23, 2022
Merged

Post-release website fixes #4038

merged 1 commit into from Aug 23, 2022

Conversation

Murderlon
Copy link
Member

  • Bring back Transloadit and Image Editor docs
  • Fix yarn start
  • Correct indentation in migration guide
  • Update Robodog migration example to use correct imports

@Murderlon Murderlon requested a review from aduh95 August 23, 2022 11:40
aduh95
aduh95 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@aduh95 aduh95 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's happening with File Processing section, it should still be there.

@Murderlon
Copy link
Member Author

I'm not sure what's happening with File Processing section, it should still be there.

I always thought it was weird that Transloadit was under there, while all other uploaders are under destinations. So this is better anyway.

@Murderlon Murderlon merged commit ff32dde into main Aug 23, 2022
@Murderlon Murderlon deleted the website-fixes branch August 23, 2022 11:48
@kvz
Copy link
Member

kvz commented Aug 23, 2022

You can use uppy and transloadit without uploading anything. And you can use S3 or Tus in conjunction with Transloadit, and then Transloadit may save results in a final destination that may yet again be different, so i don't think Transloadit it is the same thing as a destination, and may deserve different category? Or maybe i misunderstood this thread

@Murderlon
Copy link
Member Author

You can use uppy and transloadit without uploading anything. And you can use S3 or Tus in conjunction with Transloadit, and then Transloadit may save results in a final destination that may yet again be different, so i don't think Transloadit it is the same thing as a destination, and may deserve different category? Or maybe i misunderstood this thread

In the new websites I've rethought all categories. There S3, Tus, and Transloadit appear under "Upload strategies", as that's the common denominator. I think we're pushing for the new website now so we can keep the current one familiar for the users.

arturi
arturi reviewed Aug 23, 2022
View reviewed changes
website/src/docs/migration-guides.md
@@ -71,7 +65,7 @@ new Uppy()
.use(ScreenCapture, { target: Dashboard })
.use(ImageEditor, { target: Dashboard })
.use(Transloadit, {
service: TRANSLOADIT_SERVICE_URL,
service: 'https://api2.transloadit.com',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set by default, so probably ok to skip.

@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Merged
github-actions bot added a commit that referenced this pull request Aug 30, 2022
@github-actions
Release: uppy@3.0.1 (#4068)
feee2af 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/angular             |   0.4.1 | @uppy/store-default       |   3.0.1 |
| @uppy/audio               |   1.0.1 | @uppy/store-redux         |   3.0.1 |
| @uppy/aws-s3              |   3.0.1 | @uppy/svelte              |   3.0.0 |
| @uppy/aws-s3-multipart    |   3.0.1 | @uppy/thumbnail-generator |   3.0.1 |
| @uppy/companion           |   4.0.1 | @uppy/transloadit         |   3.0.1 |
| @uppy/companion-client    |   3.0.1 | @uppy/tus                 |   3.0.1 |
| @uppy/core                |   3.0.1 | @uppy/utils               |   5.0.1 |
| @uppy/dashboard           |   3.0.1 | @uppy/webcam              |   3.1.0 |
| @uppy/react               |   3.0.1 | @uppy/xhr-upload          |   3.0.1 |
| @uppy/remote-sources      |   1.0.1 | uppy                      |   3.0.1 |

- @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / #4047)
- meta: upgrade to Jest 29 (Antoine du Hamel / #4049)
- @uppy/svelte: update peer dependencies (Antoine du Hamel / #4065)
- @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / #4062)
- @uppy/vue: fix missing component in docs (Antoine du Hamel / #4063)
- @uppy/angular: fix compiler warning (Antoine du Hamel / #4064)
- meta: improve CI npm install time (Antoine du Hamel / #4058)
- meta: example: fix Angular example package name (Antoine du Hamel / #4060)
- meta: upgrade to TypeScript 4.8 (Antoine du Hamel / #4048)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / #4055)
- @uppy/transloadit: improve deprecation notice (Antoine du Hamel / #4056)
- @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / #4054)
- @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / #4043)
- @uppy/companion: Fix Companion license (Merlijn Vos / #4044)
- e2e: add tests for AWS (Antoine du Hamel / #3665)
- meta: Only publish Companion to Dockerhub on release (Merlijn Vos / #4037)
- meta: fix linter warnings (Antoine du Hamel / #4039)
- @uppy/utils: Post-release website fixes (Merlijn Vos / #4038)
- @uppy/angular: fix peer dependencies (Antoine du Hamel / #4035)
- meta: uppy.io homepage: Add Tus (Artur Paikin)
- meta: Fix uppy.io homepage example (Artur Paikin)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@github-actions
Release: uppy@3.0.1 (transloadit#4068)
e2a0ec2 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/angular             |   0.4.1 | @uppy/store-default       |   3.0.1 |
| @uppy/audio               |   1.0.1 | @uppy/store-redux         |   3.0.1 |
| @uppy/aws-s3              |   3.0.1 | @uppy/svelte              |   3.0.0 |
| @uppy/aws-s3-multipart    |   3.0.1 | @uppy/thumbnail-generator |   3.0.1 |
| @uppy/companion           |   4.0.1 | @uppy/transloadit         |   3.0.1 |
| @uppy/companion-client    |   3.0.1 | @uppy/tus                 |   3.0.1 |
| @uppy/core                |   3.0.1 | @uppy/utils               |   5.0.1 |
| @uppy/dashboard           |   3.0.1 | @uppy/webcam              |   3.1.0 |
| @uppy/react               |   3.0.1 | @uppy/xhr-upload          |   3.0.1 |
| @uppy/remote-sources      |   1.0.1 | uppy                      |   3.0.1 |

- @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / transloadit#4047)
- meta: upgrade to Jest 29 (Antoine du Hamel / transloadit#4049)
- @uppy/svelte: update peer dependencies (Antoine du Hamel / transloadit#4065)
- @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / transloadit#4062)
- @uppy/vue: fix missing component in docs (Antoine du Hamel / transloadit#4063)
- @uppy/angular: fix compiler warning (Antoine du Hamel / transloadit#4064)
- meta: improve CI npm install time (Antoine du Hamel / transloadit#4058)
- meta: example: fix Angular example package name (Antoine du Hamel / transloadit#4060)
- meta: upgrade to TypeScript 4.8 (Antoine du Hamel / transloadit#4048)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / transloadit#4055)
- @uppy/transloadit: improve deprecation notice (Antoine du Hamel / transloadit#4056)
- @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / transloadit#4054)
- @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / transloadit#4043)
- @uppy/companion: Fix Companion license (Merlijn Vos / transloadit#4044)
- e2e: add tests for AWS (Antoine du Hamel / transloadit#3665)
- meta: Only publish Companion to Dockerhub on release (Merlijn Vos / transloadit#4037)
- meta: fix linter warnings (Antoine du Hamel / transloadit#4039)
- @uppy/utils: Post-release website fixes (Merlijn Vos / transloadit#4038)
- @uppy/angular: fix peer dependencies (Antoine du Hamel / transloadit#4035)
- meta: uppy.io homepage: Add Tus (Artur Paikin)
- meta: Fix uppy.io homepage example (Artur Paikin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturi arturi arturi left review comments

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Murderlon @kvz @arturi @aduh95