Adds optional COMPANION_S3_PREFIX for companion #4312
Conversation
| * @returns {string} | ||
| */ | ||
| function getS3Prefix () { | ||
| return `${process.env.COMPANION_S3_PREFIX}/ || ''` |
There was a problem hiding this comment.
thanks for the pr! did you actually test this? 😅
`${undefined}/ || ''` becomes "undefined/ || ''"
`${'myprefix'}/ || ''` becomes "myprefix/ || ''"
on another note I think we shouldn't put env variables inside getS3Prefix because this function is also used by the non-standalone companion, which doesn't use process.env at all. I think the prefix should be an argument to defaultGetKey
There was a problem hiding this comment.
I'm not gonna lie. No I didn't test. It was a very quick attempt to get the ball rolling. Plus too many years as a manager means I am definitely not a Javascript developer!
There was a problem hiding this comment.
@mifi Had another crack
|
thanks! there was still some issues so I had to make some edits, but you haven't allowed me to push to your PR branch so I created a new PR: #4320 - closing this |
As per #4050 this adds an optional environment variable that can be used when in standalone server mode to set the AWS S3 Prefix for a file.