Hide upload button when state is recovered if hideUploadButton is true #4657
+46
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddy-jo
force-pushed
the
upload-button-recovered-state
branch
from
6e4b1d0
to
6f3ff0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of a change for the behavior documented in this community forum post. When Golden Retriever is used, recovered state overrides the user-supplied option for
hideUploadButton; this change makes the status bar not render the button if state has been recovered.There may be a bit of styling changes required if the direction of this PR is acceptable. If the button is not rendered and the progress bar has
display: none, the container is still not hidden and has the same height as if it had contents.Alternatively, I understand if the current behavior is intended and developers are responsible for hiding the button and container via our own CSS. That seems perfectly reasonable.
I will be unavailable for the next week but appreciate any feedback on this PR. Thank you!