Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prepublishOnly #4682

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix prepublishOnly #4682

wants to merge 4 commits into from

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Sep 15, 2023

doesn't work on yarn
yarnpkg/berry#2305

@Murderlon
Copy link
Member

LGTM but CI is failing

@mifi
Copy link
Contributor Author

mifi commented Sep 18, 2023

Yea seems like it triggered a totally unrelated crash. Need to do some research into that build code

aduh95 and others added 3 commits September 22, 2023 15:30
"Make Uppy bundle use local version"
- it was referencing /tmp/packages although packages seem to be built to /tmp/artifacts
- it was creating rules like "@uppy/.DS_Store": "/tmp/packages/@uppy-.DS_Store-53bc22e63897fb6eb412e1365e62c4030956bfb8.tgz",
- it seemed to fail with @uppy/audio for some reason
@mifi
Copy link
Contributor Author

mifi commented Sep 24, 2023

cd packages/@uppy/companion && corepack yarn pack --install-if-needed -o /tmp/artifacts/@uppy-companion-sha.tgz fails with

Internal Error: @uppy/companion-client@file:/tmp/artifacts/@uppy-companion-client-8086769f53b23e3bd0d09e6ab5fdf75b443ef825.tgz::locator=uppy%40workspace%3Apackages%2Fuppy: ENOENT: no such file or directory, open '/tmp/artifacts/@uppy-companion-client-8086769f53b23e3bd0d09e6ab5fdf75b443ef825.tgz'

as if @uppy/companion depended on @uppy/companion-client. I really don't understand this 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants