Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add Remote Sources to Vue and Svelte #4752

Open
wants to merge 7 commits into
base: 4.x
Choose a base branch
from

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Oct 20, 2023

No description provided.

@arturi arturi requested a review from aduh95 October 23, 2023 12:14
examples/vue3/src/App.vue Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <antoine@transloadit.com>
@aduh95
Copy link
Member

aduh95 commented Oct 23, 2023

Are you able to get it working? I'm getting CORS error if I try a remote source? I tried the Vue app with "Import from link"

@arturi
Copy link
Contributor Author

arturi commented Oct 23, 2023

Yeah the companionUrl there is just an example, it won't work without it, but to make it actually work you have to run companion locally, which I thought is out of scope of this example. Maybe in this case RemoteSources shoudn't be in this example at all 🤔

@aduh95 aduh95 changed the base branch from main to 4.x March 29, 2024 09:09
@aduh95
Copy link
Member

aduh95 commented Mar 29, 2024

There are CORS errors when trying to load companion.uppy.io from localhost, I'm not sure what would be the correct way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants