Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some types in core #4912

Open
wants to merge 1 commit into
base: upload-progress-stale-file
Choose a base branch
from
Open

Commits on Feb 6, 2024

  1. fix some types in core

    1. don't type assert opts, but instead use default values
    so that typescript understands it.
    This will prevent `this.opts` looking like they are required
    when they in reality are undefined (at runtime).
    This change also uncovered the fact that `locale` is in fact optional,
    so change types to reflect the fact.
    This change also fixes the problem where any options set to `undefined` in the constructor
    would overwrite any default options, example:
    { ...{ id: 'uppy' }, ...{ id: undefined } } becomes { id: undefined }
    
    2. remove some other unsafe type assertions
    mifi committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e4daea9 View commit details
    Browse the repository at this point in the history