Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update @uppy/aws-s3 docs #5093

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

docs: update @uppy/aws-s3 docs #5093

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Apr 16, 2024

Refs: #5076
Refs: #5075
Refs: #5070

@aduh95 aduh95 added the 4.0 For the 4.0 major version label Apr 16, 2024
@aduh95 aduh95 requested a review from Murderlon April 16, 2024 15:36
Copy link
Contributor

Diff output files
No diff

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the wrong way around, aws-s3-multipart docs should move into aws-s3 and aws-s3-multipart should be removed?

@@ -41,7 +41,7 @@ milliseconds on uploading.

**In short**

- We recommend to set [`shouldUseMultipart`][] to enable multipart uploads only
- We recommend the default value of [`shouldUseMultipart`][], which enable multipart uploads only
for large files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for large files.
for large files (100 MiB).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 For the 4.0 major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants