fix: make the native addon context-aware #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Electron 14, all native addons must be context-aware. Therefore, in order to make node-tree-sitter run with Electron >= 14, it has to be context-aware. Ref: electron/electron#18397 In this commit, NAN_MODULE_WORKER_ENABLED is used to make the native addon context-aware. It will allow context as the third param but will ignore it. This change doesn't mean that the addon will be safe to be initialised multiple times so can be run on worker threads though. Perhaps, someone with better understanding of the library need to implement AddEnvironmentCleanupHook to clean up resources. Ref: https://nodejs.org/api/addons.html#context-aware-addons
verhovsky
changed the title
|
It won't really be context aware without also taking care of any static references to JS values the module currently uses. |
|
My PR for making it truly context aware was merged, this one can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Electron 14, all native add-ons must be context-aware. Therefore, in order to make
node-tree-sitterrun with Electron >= 14, it has to be context-aware. Ref: electron/electron#18397In this PR,
NAN_MODULE_WORKER_ENABLEDis used to make the native addon context-aware. It will allow context as the third param but will ignore context. Although context param will be accepted, this change doesn't mean that the addon will be safe to be initialised multiple times and can be run safely on worker threads. Perhaps, someone with a better understanding of the library helps to implement AddEnvironmentCleanupHook to clean up global static resources. Ref: https://nodejs.org/api/addons.html#context-aware-addonsAnother minor change:
xcode_settingssettings are consolidated into a single place.