Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new features (OCaml 4.12+) #50

Merged
merged 6 commits into from
Mar 11, 2021
Merged

Conversation

314eter
Copy link
Collaborator

@314eter 314eter commented Feb 27, 2021

@314eter
Copy link
Collaborator Author

314eter commented Feb 27, 2021

The Github Actions tests don't run apparently, but they are failing: https://github.com/314eter/tree-sitter-ocaml/runs/1994780189

This is not related to changes in this PR, they were fine before I updated the examples in the last commit: https://github.com/314eter/tree-sitter-ocaml/runs/1994761493

With this (same) content in test.ml and test.mli, tree-sitter parse test.ml is fine but tree-sitter parse test.mli fails.

module type T = sig
  val f : ?x (**) : int -> int
end

This is really weird, since the ocaml and interface parsers are almost the same. The comment is parsed by an external scanner, which does return true, but tree-sitter acts like it returns false and then fails to parse the comment.

@maxbrunsfeld Is this a known bug in tree-sitter? It seems to be solved in tree-sitter 0.18.

@undu
Copy link
Contributor

undu commented Feb 27, 2021

The Github Actions tests don't run apparently,

I think the branches field for the pull request should be removed, not sure why it's limited to some names

  pull_request:
    branches:
      - '**:**'

@314eter
Copy link
Collaborator Author

314eter commented Feb 27, 2021

@undu That was indeed the problem, thanks.

@314eter
Copy link
Collaborator Author

314eter commented Mar 11, 2021

I rebased this PR on master, and tree-sitter 0.19 fixes the failing tests.

@314eter 314eter merged commit 2f962cf into tree-sitter:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants