-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new features (OCaml 4.12+) #50
Conversation
314eter
commented
Feb 27, 2021
- Hash sign in prefix operators (Add ppx-only unary operators ocaml/ocaml#9429)
- Let punning (Syntax proposal: let punning ocaml/ocaml#10013)
- Naming existentials in patterns (Allow to name existentials in pattern-matching ocaml/ocaml#9584)
- Module type substitutions (Module type substitutions ocaml/ocaml#10133)
The Github Actions tests don't run apparently, but they are failing: https://github.com/314eter/tree-sitter-ocaml/runs/1994780189 This is not related to changes in this PR, they were fine before I updated the examples in the last commit: https://github.com/314eter/tree-sitter-ocaml/runs/1994761493 With this (same) content in module type T = sig
val f : ?x (**) : int -> int
end This is really weird, since the @maxbrunsfeld Is this a known bug in tree-sitter? It seems to be solved in tree-sitter 0.18. |
I think the branches field for the pull request should be removed, not sure why it's limited to some names pull_request:
branches:
- '**:**' |
@undu That was indeed the problem, thanks. |
I rebased this PR on master, and tree-sitter 0.19 fixes the failing tests. |