Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modus Content tree - Custom Action Bar - Keyboard navigation is not there for Drag and drop option #1597

Open
2 tasks done
HarshithaNous opened this issue Jul 31, 2023 · 3 comments · May be fixed by #2523
Open
2 tasks done

Modus Content tree - Custom Action Bar - Keyboard navigation is not there for Drag and drop option #1597

HarshithaNous opened this issue Jul 31, 2023 · 3 comments · May be fixed by #2523
Assignees
@ElishaSamPeterPrabhu
Labels
3 3 story points improvement Improvement (Dev) to an existing control modus Bugs and features reported by Modus Team modus-tree-view QA Issues identified in the QA process

Comments

@HarshithaNous
Copy link

Prerequisites

Describe the issue

Modus Content tree - Custom Action Bar - Keyboard navigation is not there for Drag and drop option

image

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox, Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

Medium

What product/project are you using Modus Components for ?

QA

What is your team/division name ?

QA

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response
@HarshithaNous HarshithaNous added bug Something is wrong and needs to be addressed modus Bugs and features reported by Modus Team QA Issues identified in the QA process labels Jul 31, 2023
@rthanga1
Copy link
Contributor

rthanga1 commented Dec 19, 2023 •
edited

  1. The action bar should be accessible using the keys. When the action bar is selected using tab key, the user can move item up and down using the arrow keys
  2. The focus border seems be wrong. Both can be fixed in the same PR

Image

@rthanga1 rthanga1 added 2 2 story points improvement Improvement (Dev) to an existing control and removed bug Something is wrong and needs to be addressed labels Dec 19, 2023
@cjwinsor
Copy link
Contributor

Behavior should be similar to the table header moving.

@cjwinsor
Copy link
Contributor

cjwinsor commented Apr 3, 2024

The focus border will be handled with #2162

Goal of this ticket is to allow the reorder icon to be tabbed into. On enter or space, it "pops out" and with the up and down arrows it will move the blue placement border and on space or enter will commit the location and move the item.

@cjwinsor cjwinsor added 3 3 story points and removed 2 2 story points labels Apr 18, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu self-assigned this May 2, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request May 14, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
3 3 story points improvement Improvement (Dev) to an existing control modus Bugs and features reported by Modus Team modus-tree-view QA Issues identified in the QA process
Projects
Modus Web Components
Status: PR Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Content tree: Keyboard navigation to move items trimble-oss/modus-web-components
4 participants
@cjwinsor @rthanga1 @ElishaSamPeterPrabhu @HarshithaNous