Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content tree: Keyboard navigation to move items #2523

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented May 14, 2024

Description

  • Added Keyboard navigation to move items from one position to another

References
Fixes #1597

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented May 14, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit def36d5
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/665d500e31382700084157cc
😎 Deploy Preview https://deploy-preview-2523--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjwinsor
Copy link
Contributor

@ElishaSamPeterPrabhu 2 things:
When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

@ElishaSamPeterPrabhu
Copy link
Collaborator Author

@ElishaSamPeterPrabhu 2 things: When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

Updated the up and down behavior as expected and added escape to cancel draggable state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modus Content tree - Custom Action Bar - Keyboard navigation is not there for Drag and drop option
2 participants